fix: Add jump DDOS protection #710
Merged
+6,355
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nashtare
requested review from
0xaatif,
muursh,
wborgeaud and
LindaGuiga
as code owners
github-actions
bot
added
crate: trace_decoder
Nashtare
force-pushed
the
fix/ddos_jump
branch
from
803e459
to
ed9a164
Compare
0xaatif
approved these changes
Oct 8, 2024
muursh
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were currently allowing any
u32destination for JUMP / JUMPI opcodes. This is wasteful and a DDOS vector, as this forces us to allocate possible huge chunks of memory for each traversed context, if we call an invalid JUMP to sayu32::MAX.Given that we know contract bytecodes are limited (0x6000 bytes for Eth mainnet / 0x8000 for Polygon PoS), we can change the check to this instead.
Added a regression test (block 978 of the test chain), that requires both:
0x0000000000000000000000000000000000000000000000000000000000000401in their inputs, 6 in this block)4.5/N @praetoriansentry